This revision was automatically updated to reflect the committed changes.
Closed by commit rL316885: [analyzer] Handle ObjC messages conservatively in
CallDescription (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D37470?vs=120598&id=120778#toc
Repository:
rL LLVM
ht
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Thanks Gabor. Looks great to me!
https://reviews.llvm.org/D37470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
xazax.hun updated this revision to Diff 120598.
xazax.hun added a comment.
- Added a separate test case as per Devin's suggestion
https://reviews.llvm.org/D37470
Files:
lib/StaticAnalyzer/Core/CallEvent.cpp
test/Analysis/block-in-critical-section.m
Index: test/Analysis/block-in-critical-s
xazax.hun added a comment.
In https://reviews.llvm.org/D37470#906717, @dcoughlin wrote:
> I think it would be better to add a new
> "test/Analysis/block-in-critical-section.m" file rather than enabling a
> random alpha checker in a file that tests the analyzer core.
My reasoning was that the
dcoughlin added a comment.
I think it would be better to add a new
"test/Analysis/block-in-critical-section.m" file rather than enabling a random
alpha checker in a file that tests the analyzer core.
https://reviews.llvm.org/D37470
___
cfe-commits
xazax.hun updated this revision to Diff 120233.
xazax.hun added a comment.
Herald added a subscriber: szepet.
- Modify a test to trigger the assertion fail before the patch is applied.
https://reviews.llvm.org/D37470
Files:
lib/StaticAnalyzer/Core/CallEvent.cpp
test/Analysis/objc-message.m
vsk added a comment.
Can you add a test?
Repository:
rL LLVM
https://reviews.llvm.org/D37470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
The users of CallDescription no longer need to make sure that the called
function is a C function. This makes the API usage easier and it conservatively
will never match ObjC Messages. In the future, this
