[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-05 Thread Andrey Kasaurov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312524: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain (authored by kasaurov). Changed prior to commit: https://reviews.llvm.org/D37386?vs=113780&id=113825#toc Repository: rL LLV

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-05 Thread Evgeny Mankov via Phabricator via cfe-commits
emankov accepted this revision. emankov added a comment. LGTM https://reviews.llvm.org/D37386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D37386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-04 Thread Andrey Kasaurov via Phabricator via cfe-commits
kasaurov updated this revision to Diff 113780. kasaurov added a comment. Test added to check passing of -On/default https://reviews.llvm.org/D37386 Files: lib/Driver/ToolChains/AMDGPU.cpp lib/Driver/ToolChains/AMDGPU.h test/Driver/amdgpu-toolchain-opencl.cl Index: test/Driver/amdgpu-tool

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-04 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-04 Thread Andrey Kasaurov via Phabricator via cfe-commits
kasaurov added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:60 bool IsIntegratedAssemblerDefault() const override { return true; } + llvm::opt::DerivedArgList * + TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch, emanko

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-04 Thread Andrey Kasaurov via Phabricator via cfe-commits
kasaurov updated this revision to Diff 113767. kasaurov added a comment. Several requested changes: - move map initialization out of header file -- visually it looks better in .h file, but logically it should be in .cpp - add assert() in getOptionDefault() -- check for unknown to OptionsDefault

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Is it possible to add a test for this? Thanks. https://reviews.llvm.org/D37386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-01 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:44 +private: + const std::map OptionsDefault = { + {options::OPT_O, "3"}, Is it really needed to create map in the header? https://reviews.llvm.org/D37386 __

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-01 Thread Evgeny Mankov via Phabricator via cfe-commits
emankov added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.cpp:60-62 + for (auto *A : Args) { +DAL->append(A); + } redundant braces Comment at: lib/Driver/ToolChains/AMDGPU.cpp:74-75 +// as they defined that way in Option

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

2017-09-01 Thread Andrey Kasaurov via Phabricator via cfe-commits
kasaurov created this revision. Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng, kzhuravl. In current OpenCL implementation some options are set in OpenCL RT/Driver, which causes discrepancy between online and offline paths. Implement infrastructure to move options fr