iid_iunknown added a comment.
Thanks for reviewing this!
Repository:
rL LLVM
https://reviews.llvm.org/D37336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D37336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
iid_iunknown added a comment.
> Do you think you can write a test for your patch that will work on the
> buildbots we have?
I am afraid, this is not possible with the existing buildbots. `--target` does
not affect the default triple. There is `LLVM_TARGET_TRIPLE_ENV` that allows to
override th
hans added a comment.
In https://reviews.llvm.org/D37336#857814, @iid_iunknown wrote:
> In https://reviews.llvm.org/D37336#857802, @hans wrote:
>
> > But why isn't that failure showing on some buildbot, then?
>
>
> The test needs `system-windows` to run:
>
> // REQUIRES: system-windows
>
>
> Th
iid_iunknown added a comment.
In https://reviews.llvm.org/D37336#857802, @hans wrote:
> But why isn't that failure showing on some buildbot, then?
The test needs `system-windows` to run:
// REQUIRES: system-windows
There is no windows buildbot that builds clang defaulted to the AArch64 targ
hans added a comment.
Seems reasonable, but should probably have a test.
> This can be observed on the clang's Driver/cl-pch.c test with AArch64 as a
> default target.
But why isn't that failure showing on some buildbot, then?
Repository:
rL LLVM
https://reviews.llvm.org/D37336
iid_iunknown created this revision.
Herald added subscribers: kristof.beyls, aemerson.
Currently object format is taken from the default target triple. For toolchains
with a non-COFF default target this may result in an object format
inappropriate for pc-windows and lead to compilation issues.
