erichkeane added a comment.
In https://reviews.llvm.org/D37312#858217, @anatol.pomozov wrote:
> Thank you folks for your work.
>
> By the way when these changes are going to be released? clang 6.0?
Most likely. Its too late to get into 5.0, and 6.0 hasn't been branched yet.
Repository:
rL
anatol.pomozov added a comment.
Thank you folks for your work.
By the way when these changes are going to be released? clang 6.0?
Repository:
rL LLVM
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312281: Add documentation for force_align_arg_pointer
function attribute (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D37312?vs=113458&id=113469#toc
Repository:
rL LLVM
erichkeane added a comment.
In https://reviews.llvm.org/D37312#858108, @aaron.ballman wrote:
> LGTM! Thank you for working on this!
Did you want to land this, or should I?
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@l
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you for working on this!
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
anatol.pomozov updated this revision to Diff 113458.
https://reviews.llvm.org/D37312
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
===
--- include/clang/Basic/AttrDocs
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2812
+Legacy x86 code uses 4-byte stack alignment. Newer aligned SSE instructions
+(like 'movaps') that work with stack require operands to be 16-byte aligned.
+This attribute realigns stack in the f
erichkeane added a comment.
Looks good to me, but I want to give @aaron.ballman a chance to take a look
before this gets accepted.
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
anatol.pomozov updated this revision to Diff 113340.
https://reviews.llvm.org/D37312
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
===
--- include/clang/Basic/AttrDocs
erichkeane added a comment.
Aaron should have final say, but I've included my 2 cents.
Comment at: include/clang/Basic/AttrDocs.td:2816
+
+Note that x86_64 ABI forces 16-byte stack alignment at the caller side. Taking
+it into account 'force_align_arg_pointer' is not needed at
anatol.pomozov added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2809
+ let Content = [{
+Use this attribute to force stack alignment.
+
Feel free to reword the documentation (English is not my native language).
Let me know if something is not
11 matches
Mail list logo
