mgorny added a comment.
Thanks a lot for taking care of this.
Repository:
rL LLVM
https://reviews.llvm.org/D37278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312048: Restore clang_rt library name on i686-android.
(authored by eugenis).
Changed prior to commit:
https://reviews.llvm.org/D37278?vs=113167&id=113170#toc
Repository:
rL LLVM
https://reviews.llv
eugenis updated this revision to Diff 113167.
eugenis added a comment.
+comment
https://reviews.llvm.org/D37278
Files:
clang/lib/Driver/ToolChain.cpp
clang/test/Driver/sanitizer-ld.c
compiler-rt/cmake/Modules/AddCompilerRT.cmake
Index: compiler-rt/cmake/Modules/AddCompilerRT.cmake
=
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Thanks! Looks good to me.
Comment at: clang/lib/Driver/ToolChain.cpp:308
+ if (TC.getArch() == llvm::Triple::x86 && Triple.isAndroid())
+return "i686";
Ma
eugenis created this revision.
Herald added a subscriber: srhines.
Recent changes canonicalized clang_rt library names to refer to
"i386" on all x86 targets. Android historically uses i686.
This change adds a special case to keep i686 in all clang_rt
libraries when targeting Android.
https://re
