[PATCH] D37231: Add half load and store builtins

2017-09-07 Thread Jan Vesely via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312742: [OpenCL] Add half load and store builtins (authored by jvesely). Changed prior to commit: https://reviews.llvm.org/D37231?vs=113624&id=114240#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D37231: Add half load and store builtins

2017-09-07 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Yes, sorry overlooked that. :) LGTM! Thanks! Repository: rL LLVM https://reviews.llvm.org/D37231 ___ cfe-commits mailing list cfe-commit

[PATCH] D37231: Add half load and store builtins

2017-09-06 Thread Jan Vesely via Phabricator via cfe-commits
jvesely marked 2 inline comments as done. jvesely added inline comments. Comment at: test/CodeGenOpenCL/no-half.cl:27 + foo[0] = __builtin_load_halff(bar); +// CHECK: [[HALF_VAL:%.*]] = load +// CHECK: [[FULL_VAL:%.*]] = fpext half [[HALF_VAL]] to float Ana

[PATCH] D37231: Add half load and store builtins

2017-09-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: test/CodeGenOpenCL/no-half.cl:27 + foo[0] = __builtin_load_halff(bar); +// CHECK: [[HALF_VAL:%.*]] = load +// CHECK: [[FULL_VAL:%.*]] = fpext half [[HALF_VAL]] to float jvesely wrote: > Anastasia wrote: > > Minor

[PATCH] D37231: Add half load and store builtins

2017-09-04 Thread Jan Vesely via Phabricator via cfe-commits
jvesely requested review of this revision. jvesely added a comment. please let me know if your accept still stands for the modified version. Repository: rL LLVM https://reviews.llvm.org/D37231 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D37231: Add half load and store builtins

2017-09-01 Thread Jan Vesely via Phabricator via cfe-commits
jvesely updated this revision to Diff 113624. jvesely added a comment. mark load pointers const Repository: rL LLVM https://reviews.llvm.org/D37231 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h lib/Basic/Builtins.cpp lib/CodeGen/CGBuiltin.cpp test/CodeGenOp

[PATCH] D37231: Add half load and store builtins

2017-09-01 Thread Jan Vesely via Phabricator via cfe-commits
jvesely added inline comments. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vfh*", "n") Anastasia wrote: > jvesely wrote: > > Anastasia wrote: > >

[PATCH] D37231: Add half load and store builtins

2017-09-01 Thread Jan Vesely via Phabricator via cfe-commits
jvesely updated this revision to Diff 113588. jvesely marked 6 inline comments as done. jvesely edited the summary of this revision. jvesely added a comment. fully check loads in tests Repository: rL LLVM https://reviews.llvm.org/D37231 Files: include/clang/Basic/Builtins.def include/cla

[PATCH] D37231: Add half load and store builtins

2017-09-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: test/CodeGenOpenCL/no-half.cl:19 + __builtin_store_half(foo, bar); +// CHECK: [[HALF_VAL:%.*]] = fptrunc double %foo to half +// CHECK: store half [[HALF_VAL]], half addrspace({{.}})* %bar, align 2 Would it make

[PATCH] D37231: Add half load and store builtins

2017-09-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. LGTM! Thanks! Repository: rL LLVM https://reviews.llvm.org/D37231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37231: Add half load and store builtins

2017-09-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vf

[PATCH] D37231: Add half load and store builtins

2017-08-29 Thread Jan Vesely via Phabricator via cfe-commits
jvesely updated this revision to Diff 113190. jvesely added a comment. restrict builtins to OCLC langauges Repository: rL LLVM https://reviews.llvm.org/D37231 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h lib/Basic/Builtins.cpp lib/CodeGen/CGBuiltin.cpp tes

[PATCH] D37231: Add half load and store builtins

2017-08-29 Thread Jan Vesely via Phabricator via cfe-commits
jvesely added inline comments. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vfh*", "n") Anastasia wrote: > I think this should be a language built

[PATCH] D37231: Add half load and store builtins

2017-08-29 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vfh*", "n") I think this should be a language builtin (see above) bu