[PATCH] D37203: [Bash-autocompletion] Follow up patch for D36782

2017-08-28 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi abandoned this revision. yamaguchi added a comment. https://reviews.llvm.org/D37217 has already landed, so we don't need this anymore. https://reviews.llvm.org/D37203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D37203: [Bash-autocompletion] Follow up patch for D36782

2017-08-28 Thread Rui Ueyama via Phabricator via cfe-commits
ruiu added a comment. Technically, this patch fixes your issue, but I don't think this is a good way of fixing it because `parse()` function now has an internal state which is not obvious to the user of the function. Can you review https://reviews.llvm.org/D37217? This is an alternative fix tha

[PATCH] D37203: [Bash-autocompletion] Follow up patch for D36782

2017-08-28 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi created this revision. https://reviews.llvm.org/D36782 broke lld buildbots, because I've changed OptionInfo's type from ArrayRef to std::vector, so it became a copy, not a reference. In this patch, I changed Table to static, so that it won't be freed after the return. However, I'm not s