davidxl accepted this revision.
davidxl added a comment.
lgtm
https://reviews.llvm.org/D37091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Thanks, looks great.
https://reviews.llvm.org/D37091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielcdh updated this revision to Diff 112604.
danielcdh marked an inline comment as done.
danielcdh added a comment.
update
https://reviews.llvm.org/D37091
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/ToolC
rsmith added inline comments.
Comment at: test/CodeGen/thinlto-profile-sample-accurate.c:2-4
+// RUN: %clang -O2 %s -flto=thin -fprofile-sample-accurate -c -o %t.o
+// RUN: llvm-lto -thinlto -o %t %t.o
+// RUN: %clang_cc1 -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -emit-llvm -o
danielcdh updated this revision to Diff 112601.
danielcdh added a comment.
Herald added subscribers: eraman, mehdi_amini.
Add an end-to-end test.
https://reviews.llvm.org/D37091
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cp
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please add a test that the attribute is emitted into IR. Other than that, this
looks good to me.
Comment at: include/clang/Driver/Options.td:645
+ profile is a
danielcdh updated this revision to Diff 112597.
danielcdh marked 3 inline comments as done.
danielcdh added a comment.
update
https://reviews.llvm.org/D37091
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/ToolC
rsmith added inline comments.
Comment at: docs/ClangCommandLineReference.rst:173-180
+.. option:: -faccurate-sample-profile, -fno-accurate-sample-profile
+.. program:: clang
+
+If the sample profile is accurate, callsites without profile samples are marked
+as cold. Otherwise, tr
davidxl added a comment.
Looks fine to me, but please wait for Richard's comment.
https://reviews.llvm.org/D37091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielcdh updated this revision to Diff 112574.
danielcdh marked 2 inline comments as done.
danielcdh added a comment.
updated the patch to put it into function attribute so that it works with
ThinLTO
https://reviews.llvm.org/D37091
Files:
docs/ClangCommandLineReference.rst
include/clang/D
davidxl added inline comments.
Comment at: docs/ClangCommandLineReference.rst:176
+
+If sample profile is accurate, we will mark all un-sampled callsite as cold.
Otherwise, treat un-sampled callsites as if we have no profile
+
If the sample profile is accurate,
danielcdh updated this revision to Diff 112496.
danielcdh added a comment.
add document and test
https://reviews.llvm.org/D37091
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
test/Driver/clang_f_opts.c
Index: test/Driver/clan
davidxl added a comment.
Documentation needs to be added to clang/docs/ClangCommandLineReference.rst .
There probably also needs some kind of testing for the option processing: see
clang_f_opts.c
https://reviews.llvm.org/D37091
___
cfe-commits mai
danielcdh created this revision.
Herald added a subscriber: sanjoy.
With accurate sample profile, we can do more aggressive size optimization. For
some size-critical application, this can reduce the text size by 20%
https://reviews.llvm.org/D37091
Files:
include/clang/Driver/Options.td
lib
14 matches
Mail list logo
