[PATCH] D37001: [clang-diff] Use data collectors for node comparison

johannes updated this revision to Diff 121647. johannes added a comment. use raw source code of owned tokens instead https://reviews.llvm.org/D37001 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-h

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

johannes added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537 + +#include "../../AST/DeclDataCollectors.inc" + arphaman wrote: > I didn't realize that you're including files from within `lib`. That's not > ideal. You should add a pre-commit tha

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537 + +#include "../../AST/DeclDataCollectors.inc" + I didn't realize that you're including files from within `lib`. That's not ideal. You should add a pre-commit that moves the *.inc fi

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

johannes added a comment. In https://reviews.llvm.org/D37001#852442, @arphaman wrote: > Can you remove `getNodeValue` now or do you still need it? It is only used in the client, I think it makes sense to move it there, or to remove it altogether. I think I'd keep it in the client for now, to d

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

arphaman added a comment. Can you remove `getNodeValue` now or do you still need it? https://reviews.llvm.org/D37001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D37001 Files: lib/Tooling/ASTDiff/ASTDiff.cpp Index: lib/Tooling/ASTDiff/ASTDiff.cpp === --- lib/Tooling/ASTDiff/ASTDiff.cpp +++ lib/Tooli