This revision was automatically updated to reflect the committed changes.
Closed by commit rL311476: [clang-diff] Refactor stop-after command-line flag
(authored by jgravelle).
Repository:
rL LLVM
https://reviews.llvm.org/D36989
Files:
cfe/trunk/test/Tooling/clang-diff-topdown.cpp
cfe/tru
johannes added a comment.
In https://reviews.llvm.org/D36989#848835, @jgravelle-google wrote:
> If you have more stop-after options it'd probably be simpler to leave it as
> one field. I'll just rename it to "stop-diff-after" to avoid the name
> collision.
Ok, you can go ahead. Or, if I shoul
jgravelle-google updated this revision to Diff 112193.
jgravelle-google added a comment.
- Undo refactor, just change name
https://reviews.llvm.org/D36989
Files:
test/Tooling/clang-diff-topdown.cpp
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.cpp
==
jgravelle-google added a comment.
If you have more stop-after options it'd probably be simpler to leave it as one
field. I'll just rename it to "stop-diff-after" to avoid the name collision.
https://reviews.llvm.org/D36989
___
cfe-commits mailing l
johannes requested changes to this revision.
johannes added a comment.
This revision now requires changes to proceed.
Oh wait I get linker errors with BUILD_SHARED_LIBS=1
`undefined reference to ClangDiffCategory` in ASTDiff
https://reviews.llvm.org/D36989
___
johannes accepted this revision.
johannes added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
You can remove StopAfterTopDown from the ComparisonOptions struct definition
I have a second option stop-after option coming up but I will use another
boolean for it, i
jgravelle-google created this revision.
Herald added subscribers: aheejin, klimek.
Rename stop-after to stop-after-topdown. When building LLVM with
-DLLVM_BUILD_LLVM_DYLIB=ON, stop-after collides with the stop-after
already present in LLVM.
This also refactors the flag to a boolean, to reflect th
