[PATCH] D36802: AMDGPU: Insert __devicename__ macros

2017-08-16 Thread Tony Tye via Phabricator via cfe-commits
t-tye added inline comments. Comment at: lib/Basic/Targets/AMDGPU.cpp:364-367 + if (GPUName.empty()) +return; + + Builder.defineMacro(Twine("__") + Twine(GPUName) + Twine("__")); Should this be the following since extra macros could be after it in the futur

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

2017-08-16 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl added a comment. Do we need this for r600? https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

2017-08-16 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl created this revision. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgcn-mcpu-macro.cl test/Driver/r600-mcpu-macro.cl test/Driver/r600-mcpu.c