This revision was automatically updated to reflect the committed changes.
yamaguchi marked an inline comment as done.
Closed by commit rL311552: [Bash-autocompletion] Add support for static
analyzer flags (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36782?vs=11154
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Found one more minor comment typo. And could you do your changes to
`OptParserEmitter.cpp` all in this patch? Because Rui/Me pointed out those
things on this review, so this patch should
yamaguchi added a comment.
@ruiu
I addressed your comments in https://reviews.llvm.org/D36820, so please take a
look at it. Thank you!
https://reviews.llvm.org/D36782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ruiu added inline comments.
Comment at: clang/include/clang/Driver/CC1Options.td:104
+ ValuesCode<[{
+const char* Values =
+#define GET_CHECKERS
`const char* Values` -> `const char *Values`
Comment at: llvm/utils/TableGen/OptParserEmit
yamaguchi updated this revision to Diff 111548.
yamaguchi added a comment.
const char* Values -> const char *Values
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/include/llvm/Optio
yamaguchi updated this revision to Diff 111547.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
yamaguchi added a comment.
@ruiu
I understand your concern. However by doing this (rather than building
functions for each flag), we will be able to get all information in OptTable
itself. It is true that this is quite fragile, but adding ValuesCode to new
flag is not complicated, so I believe
yamaguchi updated this revision to Diff 111457.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
ruiu added a comment.
This patch allows us to embed a piece of C++ code to each command line option
to construct a list of argument candidates at runtime. With this patch, .inc
files generated by OptParserEmitter contain C macros that in turn include other
.inc files. That is a flexible mechani
teemperor added inline comments.
Comment at: clang/lib/Driver/DriverOptions.cpp:14
#include "llvm/Option/Option.h"
+#include
I think the C++ version of the assert header is more consistent: `#include
`
Comment at: llvm/utils/TableGen/OptPa
yamaguchi updated this revision to Diff 111318.
yamaguchi marked 7 inline comments as done.
yamaguchi added a comment.
Update diff according to Raphael's comments.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test
teemperor added a comment.
That's a really nice approach to this problem, good job Yuka! See my inline
comments for some minor remarks.
Comment at: clang/include/clang/Driver/CC1Options.td:104
+ const char* Values =
+#define GET_CHECKERS
+#define CHECKER(FULLNAME, CLASS, DESC
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
This is a patch for clang autocomplete feature.
It will collect values which -analyzer-checker takes, which is defined in
clang/StaticAnalyzer/Checkers/Checkers.inc, dynamically.
First, from ValuesCode class in Options.td, Tab
13 matches
Mail list logo
