[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 support

2017-08-18 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. Ah, my message crossed with Renato's; I only noticed it after submitting mine (looks like we agree though:-)) https://reviews.llvm.org/D36731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 support

2017-08-18 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. "They also implement the RCpc AArch64 extension from ARMv8.3-A." Perhaps you need to explain why a v8.2 core implements a v8.3 extension? Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:92 + std::vector &Features

[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 support

2017-08-18 Thread Renato Golin via Phabricator via cfe-commits
rengolin added a comment. This change seems to have nothing to do with adding core support but exposing features from CPU names. If this was required to "support" the new cores in Clang, why wasn't it needed before? If this is a new, more generic way, of getting support, shouldn't you remove

[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 support

2017-08-15 Thread Sam Parker via Phabricator via cfe-commits
samparker created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. This patch introduces support for Cortex-A75 and Cortex-A55, Arm's latest big.LITTLE A-class cores. They implement the ARMv8.2-A architecture, including the cryptography and RAS extensions,