This revision was automatically updated to reflect the committed changes.
Closed by commit rL314946: [libc++] Add site config option for ABI macros
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D36719?vs=117758&id=117759#toc
Repository:
rL LLVM
https://reviews.llv
smeenai updated this revision to Diff 117758.
smeenai added a comment.
Fix RST
https://reviews.llvm.org/D36719
Files:
CMakeLists.txt
docs/BuildingLibcxx.rst
include/__config_site.in
utils/libcxx/test/config.py
Index: utils/libcxx/test/config.py
smeenai updated this revision to Diff 117757.
smeenai added a comment.
Address comments
https://reviews.llvm.org/D36719
Files:
CMakeLists.txt
docs/BuildingLibcxx.rst
include/__config_site.in
utils/libcxx/test/config.py
Index: utils/libcxx/test/config.py
===
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D36719#841499, @smeenai wrote:
> There should probably be some documentation for this, but I couldn't think of
> the right place; the Using libc++ documentation onl
smeenai added a comment.
Ping.
https://reviews.llvm.org/D36719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
There should probably be some documentation for this, but I couldn't think of
the right place; the Using libc++ documentation only mentions the actual
configuration macros, not their corresponding cmake defines. Any suggestions?
https://reviews.llvm.org/D36719
_
smeenai created this revision.
Herald added a subscriber: mgorny.
Some ABI macros affect headers, so it's nice to have a site config
option for them. Add a LIBCXX_ABI_DEFINES cmake macro to allow
specifying a list of ABI macros to define in the site config.
The primary design constraint (as discu
