[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-22 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 112127. johannes added a comment. casing https://reviews.llvm.org/D36686 Files: tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp === --- tools/clang-diff/ClangDiff.cpp +

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-16 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 111328. johannes edited the summary of this revision. johannes added a comment. accept a commit range https://reviews.llvm.org/D36686 Files: tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp ===

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-15 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. That would be nice. Temporary checkouts are a way to solve the problem. But they might not work for all projects, like when some translation unit includes a file that's not in git using a relative path. Another solution is to use virtual file systems. A custom vfs coul

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-14 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes added a comment. In https://reviews.llvm.org/D36686#840827, @arphaman wrote: > It might be useful to have both source and destination in a different > revision. Maybe something like `-src-git-rev` and `-dst-git-rev`? Then I'd rather have a revision range such as `-git-revs ..` and if

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. It might be useful to have both source and destination in a different revision. Maybe something like `-src-git-rev` and `-dst-git-rev`? https://reviews.llvm.org/D36686 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-14 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. This adds a command line option "-git-rev=". When it is used, only one filename is accepted. The file in its version in the specified revision is compared against the current version. Note that this calls `git checkout` in the current directory. https://reviews.l