[PATCH] D36685: [clang-diff] HTML diff navigation

2017-08-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL311570: [clang-diff] HTML diff navigation (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D36685 Files: cfe/trunk/tools/clang-diff/ClangDiff.cpp Index: cfe/trunk/tools/clang-d

[PATCH] D36685: [clang-diff] HTML diff navigation

2017-08-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. LGTM. There are some unrelated highlighting bugs in HTML though, for example if you take: before: int foo(); void bar(int x) { switch (x) { case 0: bar(2); } } after: void bar(int x) { switch (x) { case 4: bar(2); brea

[PATCH] D36685: [clang-diff] HTML diff navigation

2017-08-22 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 112126. johannes added a comment. some refactoring https://reviews.llvm.org/D36685 Files: tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp === --- tools/clang-diff/Clan

[PATCH] D36685: [clang-diff] HTML diff navigation

2017-08-14 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. This adds shortcuts j and k to jump between changes. It is especially useful in diffs with few changes. https://reviews.llvm.org/D36685 Files: tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp ===