[PATCH] D36614: [clang-format] Refine trailing comment detection

2017-08-22 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir abandoned this revision. krasimir marked an inline comment as done. krasimir added a comment. This was superseded by https://reviews.llvm.org/D37007. https://reviews.llvm.org/D36614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D36614: [clang-format] Refine trailing comment detection

2017-08-22 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/FormatToken.h:397 + (!Previous || + Previous->isOneOf(tok::comma, tok::equal, tok::l_brace) || + Next->is(tok::r_brace; dja

[PATCH] D36614: [clang-format] Refine trailing comment detection

2017-08-21 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/FormatToken.h:397 + (!Previous || + Previous->isOneOf(tok::comma, tok::equal, tok::l_brace) || + Next->is(tok::r_brace; Is this list coming from existing tests?

[PATCH] D36614: [clang-format] Refine trailing comment detection

2017-08-21 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. ping https://reviews.llvm.org/D36614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36614: [clang-format] Refine trailing comment detection

2017-08-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a subscriber: klimek. This patch fixes an non-idempotency issue connected with detection of trailing comments. Consider formatting the following code with column limit at `V`: V const /* comment comment */ A = B; The comment is