[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks! LGTM! https://reviews.llvm.org/D36586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-signed-bitwise.cpp:205 + +#if 0 +// Scoped Enums must define their operations, so the overloaded operators must take care aaron.ballman wrote: > I don'

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 113246. JonasToth marked 8 inline comments as done. JonasToth added a comment. - added additional testcases, like @aaron.ballman requested - fixed diagnostics https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICP

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + JonasToth wrote: > JonasToth wrote: > > aaron.bal

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + JonasToth wrote: > aaron.ballman wrote: > > JonasToth

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 112573. JonasToth added a comment. - fix indendation in testcase https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tidy/hicpp/SignedBitwiseChec

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 112572. JonasToth added a comment. - get up to date with master - added testcase for enums https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-ti

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + aaron.ballman wrote: > JonasToth wrote: > > aaron.bal