This revision was automatically updated to reflect the committed changes.
Closed by commit rL310618: Fixed a race condition in PrecompiledPreamble.
(authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36529
Files:
cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp
Index: cfe
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG, as discussed in person, it's probably a good idea to try to get rid of the
non-file-creating version, if possible, or at least fix the comments on the
functions to make this behavior clear
ilya-biryukov added inline comments.
Comment at: lib/Frontend/PrecompiledPreamble.cpp:470-471
+ int FD;
+ auto EC = llvm::sys::fs::createTemporaryFile(Prefix, Suffix, /*ref*/ FD,
+ /*ref*/ File);
if (EC)
klimek w
klimek added inline comments.
Comment at: lib/Frontend/PrecompiledPreamble.cpp:470-471
+ int FD;
+ auto EC = llvm::sys::fs::createTemporaryFile(Prefix, Suffix, /*ref*/ FD,
+ /*ref*/ File);
if (EC)
I don't underst
ilya-biryukov added a comment.
Catched by a test from https://reviews.llvm.org/D36261.
https://reviews.llvm.org/D36529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov created this revision.
Two PrecompiledPreambles, used in parallel on separate threads,
could be writing preamble to the same temporary file.
https://reviews.llvm.org/D36529
Files:
lib/Frontend/PrecompiledPreamble.cpp
Index: lib/Frontend/PrecompiledPreamble.cpp
