[PATCH] D36492: [time-report] Add preprocessor timer

2018-02-14 Thread Brian Gesiak via Phabricator via cfe-commits
modocache abandoned this revision. modocache added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), +

[PATCH] D36492: [time-report] Add preprocessor timer

2018-02-14 Thread Andrew V. Tischenko via Phabricator via cfe-commits
avt77 added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), + UsePredefines(true)

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-23 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + MatzeB wrote: > modocache wrote: > > erik.pilkington wrote: > > > Doesn't this just start a timer and immediate

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-22 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + modocache wrote: > erik.pilkington wrote: > > Doesn't this just start a timer and immediately end the timer?

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-19 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), + UsePredefines(t

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-18 Thread Eddie Elizondo via Phabricator via cfe-commits
eduardo-elizondo added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), + UsePrede

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-16 Thread Brian Gesiak via Phabricator via cfe-commits
modocache planned changes to this revision. modocache added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + erik.pilkington wrote: > Doesn't this just start a timer and

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-16 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. This looks really usefull, thanks for working on this! Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + Doesn't this just start a timer and immediately

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-16 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-16 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Friendly ping! I think this is ready to be reviewed. It adds an additional row, `Preprocessing`, to the `Miscellaneous Ungrouped Timers` section of the `clang -ftime-report` output: ===-===

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-15 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added subscribers: vsk, mzolotukhin. modocache added a comment. Oops, sorry, didn't mean to remove the subscribers. `arc diff --verbatim` strikes again. https://reviews.llvm.org/D36492 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D36492: [time-report] Add preprocessor timer

2017-08-15 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 95. modocache retitled this revision from "[RFC][time-report] Add preprocessor timer" to "[time-report] Add preprocessor timer". modocache edited the summary of this revision. modocache removed subscribers: vsk, mzolotukhin. modocache added a comment. A