This revision was automatically updated to reflect the committed changes.
Closed by commit rL310496: [clang-tidy] Fix another crash in make-unique check.
(authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D36452
Files:
clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPt
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for the fix!
Looks good!
Comment at: test/clang-tidy/modernize-make-unique.cpp:419
+
+class UniqueFoo : public std::unique_ptr {
+ public:
I suspec
hokein created this revision.
Herald added subscribers: xazax.hun, JDevlieghere.
The crash happens when calling `reset` method without any preceding
operation like "->" or ".", this could happen in a subclass of the
"std::unique_ptr".
https://reviews.llvm.org/D36452
Files:
clang-tidy/moderniz
