This revision was automatically updated to reflect the committed changes.
Closed by commit rL310819: [clangd] Check if CompileCommand has changed on
forceReparse. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36398
Files:
clang-tools-extra/trunk/clangd/ClangdServer.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: unittests/clangd/ClangdTests.cpp:509-510
+ /*RunSynchronously=*/true);
+ // No need to sync reparses, because RunSynchronously is set
+
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D36398#834904, @klimek wrote:
> Also missing tests :)
Done :-)
Comment at: clangd/ClangdUnitStore.h:45-48
+ struct RecreateResult {
+std::shared_ptr FileInCollecti
ilya-biryukov updated this revision to Diff 110155.
ilya-biryukov added a comment.
Addressed review comments.
- Added a test for forceReparse.
- Got rid of a redundant `= nullptr` assignment.
https://reviews.llvm.org/D36398
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Clan
klimek added a comment.
Also missing tests :)
Comment at: clangd/ClangdUnitStore.cpp:45
+ .first;
+Result.RemovedFile = nullptr;
+ } else if (!compileCommandsAreEqual(It->second->getCompileCommand(),
ilya-biryukov wrote:
> klimek wrote:
> > Jus
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnitStore.cpp:45
+ .first;
+Result.RemovedFile = nullptr;
+ } else if (!compileCommandsAreEqual(It->second->getCompileCommand(),
klimek wrote:
> Just say RemovedFile = nullptr in the s
ilya-biryukov updated this revision to Diff 110016.
ilya-biryukov added a comment.
- Moved assignment `RemoveFile = nullptr` around a bit.
- Added a comment to recreateFileIfCompileCommandChanged.
https://reviews.llvm.org/D36398
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/
klimek added inline comments.
Comment at: clangd/ClangdUnitStore.cpp:45
+ .first;
+Result.RemovedFile = nullptr;
+ } else if (!compileCommandsAreEqual(It->second->getCompileCommand(),
Just say RemovedFile = nullptr in the struct?
==
ilya-biryukov created this revision.
https://reviews.llvm.org/D36398
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnitStore.cpp
clangd/ClangdUnitStore.h
Index: clangd/ClangdUnitStore.h
===
--- clangd/Cla
