Should clang warn if you request static libc++ on fuchsia? It now silently
ignores the flag, right?
On Aug 1, 2017 9:18 PM, "Petr Hosek via Phabricator via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309778: [Driver] Disable static C++ library support on
Fuchsia (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D36202?vs=109255&id=109258#toc
Repository:
rL LLVM
https://revi
phosek added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
-if (OnlyLibstdcxxStatic)
- CmdArgs.push_back("-Bdynamic");
- }
CmdArgs.push_back("-lm");
}
mc
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM. The nit below is orthogonal to this change.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
-if (O
phosek created this revision.
Herald added a subscriber: mgorny.
Don't support or build static C++ libraries for Fuchsia.
Repository:
rL LLVM
https://reviews.llvm.org/D36202
Files:
cmake/caches/Fuchsia-stage2.cmake
lib/Driver/ToolChains/Fuchsia.cpp
test/Driver/fuchsia.cpp
Index: test
