This revision was automatically updated to reflect the committed changes.
Closed by commit rL311173: [clang-diff] Add commandline arguments. (authored by
krobelus).
Changed prior to commit:
https://reviews.llvm.org/D36177?vs=109502&id=111690#toc
Repository:
rL LLVM
https://reviews.llvm.org/
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
I think you have to test the -p option too (check the compilation database can
be loaded and arguments are propagated to the parser), otherwise LGTM!
https://reviews.llvm.org/D36177
__
johannes updated this revision to Diff 109502.
johannes added a comment.
fix tests
https://reviews.llvm.org/D36177
Files:
test/Tooling/clang-diff-args.test
test/Tooling/clang-diff-basic.cpp
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.cpp
=
arphaman added inline comments.
Comment at: test/Tooling/clang-diff-args.sh:1
+RUN: echo a > %t.cpp
+
I think a '.test' extension rather than '.sh' is better
Comment at: test/Tooling/clang-diff-args.sh:3
+
+RUN: echo "CHECK: unknown type name '
johannes added a comment.
In https://reviews.llvm.org/D36177#828909, @arphaman wrote:
> There should be a test that ensures that `stop-after` works and `extra-arg`s
> are correctly passed to the compiler.
`stop-after` is not tested yet. It is also broken in this patch, I will move it
to a lat
johannes updated this revision to Diff 109415.
johannes added a comment.
add some test, replace -no-compilation-database with --
https://reviews.llvm.org/D36177
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-args.sh
test/Tooling/cl
