This revision was automatically updated to reflect the committed changes.
Closed by commit rL311172: [clang-diff] Fix some errors and inconsistencies
(authored by krobelus).
Repository:
rL LLVM
https://reviews.llvm.org/D36176
Files:
cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h
cfe/tr
johannes updated this revision to Diff 109536.
johannes edited the summary of this revision.
johannes added a comment.
update commit message
https://reviews.llvm.org/D36176
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/A
arphaman added a comment.
Ok, please include this info in the commit message.
https://reviews.llvm.org/D36176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
johannes added a comment.
In https://reviews.llvm.org/D36176#830341, @arphaman wrote:
> LGTM. Although I'm not 100% sure it's fully NFC, so if you can't come up with
> a test please justify why.
There are changes that affect the output.
Firstly the computation of the rightmost descendant; the
arphaman added a comment.
LGTM. Although I'm not 100% sure it's fully NFC, so if you can't come up with a
test please justify why.
https://reviews.llvm.org/D36176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
johannes added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96
: TreeImpl(llvm::make_unique(this, Node, AST)) {}
+ SyntaxTree(const SyntaxTree &Tree) = delete;
~SyntaxTree();
arphaman wrote:
> johannes wrote:
> > arphaman wrote:
johannes updated this revision to Diff 109414.
johannes added a comment.
move most functional changes to other commits
move constructor for Syntaxtree
https://reviews.llvm.org/D36176
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling
arphaman added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96
: TreeImpl(llvm::make_unique(this, Node, AST)) {}
+ SyntaxTree(const SyntaxTree &Tree) = delete;
~SyntaxTree();
johannes wrote:
> arphaman wrote:
> > It might be bet
johannes added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96
: TreeImpl(llvm::make_unique(this, Node, AST)) {}
+ SyntaxTree(const SyntaxTree &Tree) = delete;
~SyntaxTree();
arphaman wrote:
> It might be better to add a move co
