This revision was automatically updated to reflect the committed changes.
Closed by commit rL309810: Adapt clang-tidy checks to changing semantics of
hasDeclaration. (authored by klimek).
Repository:
rL LLVM
https://reviews.llvm.org/D36154
Files:
clang-tools-extra/trunk/clang-tidy/google/St
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good
https://reviews.llvm.org/D36154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
klimek added a comment.
ptal
https://reviews.llvm.org/D36154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek updated this revision to Diff 109287.
klimek marked an inline comment as done.
klimek added a comment.
Address review comment.
https://reviews.llvm.org/D36154
Files:
clang-tidy/google/StringReferenceMemberCheck.cpp
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/InaccurateE
bkramer added inline comments.
Comment at: clang-tidy/google/StringReferenceMemberCheck.cpp:31
+ auto String = anyOf(namedDecl(hasName("::std::string")),
recordDecl(hasName("::string")));
auto ConstString = qualType(isConstQualified(), hasDeclaration(St
klimek created this revision.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D36154
Files:
clang-tidy/google/StringReferenceMemberCheck.cpp
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/InaccurateEraseCheck.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tid
