vsk added a comment.
Reverted in r310154, because llvm-cov isn't doing a good job of displaying the
new regions properly. I'll re-land this after llvm-cov is fixed.
https://reviews.llvm.org/D35925
___
cfe-commits mailing list
cfe-commits@lists.llvm
vsk closed this revision.
vsk added a comment.
Committed in r310010
https://reviews.llvm.org/D35925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk updated this revision to Diff 109142.
vsk marked 2 inline comments as done.
vsk edited the summary of this revision.
vsk added a comment.
Thanks for the review! I'll hold off on landing this until the llvm-cov changes
are in, so that people don't hit the issue where unexpected line execution
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks, it does make sense to update llvm-cov.
LGTM:
Comment at: lib/CodeGen/CoverageMappingGen.cpp:554
+ // useful to try and create a deferred region inside o
vsk added a comment.
In https://reviews.llvm.org/D35925#823978, @arphaman wrote:
> This is awesome!
>
> I noticed in the sample output that llvm-cov is now forced to print some new
> region markers because the terminator introduces a new region on the same
> line, e.g.
>
> |// CHECK-LABEL: _Z
arphaman added a comment.
This is awesome!
I noticed in the sample output that llvm-cov is now forced to print some new
region markers because the terminator introduces a new region on the same line,
e.g.
|// CHECK-LABEL: _Z10while_loopv:
88| 1|void while_loop() {
89| 1|
vsk created this revision.
The current coverage implementation doesn't handle region termination
very precisely. Take for example an `if' statement with a `return':
void f() {
if (true) {
return; // The `if' body's region is terminated here.
}
// This line gets the same covera
