Re: [PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-31 Thread David Blaikie via cfe-commits
On Thu, Jul 27, 2017 at 8:30 AM Dehao Chen via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > danielcdh marked an inline comment as done. > danielcdh added a comment. > > Thanks for the review! > > In https://reviews.llvm.org/D35746#822498, @chandlerc wrote: > > > LGTM with a t

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-27 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh marked an inline comment as done. danielcdh added a comment. Thanks for the review! In https://reviews.llvm.org/D35746#822498, @chandlerc wrote: > LGTM with a tiny tweak below. > > Would be good to add a test that this flag is being honored, either in this > patch or in a follow-up.

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-27 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM with a tiny tweak below. Would be good to add a test that this flag is being honored, either in this patch or in a follow-up. Comment at: lib/CodeGen/BackendUtil

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-27 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. (Also, sorry for the delay reviewing this, for some reason I thought this already got reviewed and landed...) https://reviews.llvm.org/D35746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-26 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh marked 2 inline comments as done. danielcdh added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:847-859 if (PGOOpt.RunProfileGen) PGOOpt.ProfileGenFile = CodeGenOpts.InstrProfileOutput.empty() ? DefaultProfileGenName : CodeGenOpts.InstrProfileO

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-26 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh updated this revision to Diff 108316. danielcdh marked an inline comment as done. danielcdh added a comment. update https://reviews.llvm.org/D35746 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp ===

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-25 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:843 PGOOptions PGOOpt; Maybe make this an optional to avoid the big predicate below? Comment at: lib/CodeGen/BackendUtil.cpp:847-859 if (PGOOpt.RunProfileGen)

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-25 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh updated this revision to Diff 108174. danielcdh added a comment. update https://reviews.llvm.org/D35746 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp === --- lib/CodeGen/BackendUtil.cpp +++ lib

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

2017-07-21 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh created this revision. Herald added a subscriber: sanjoy. The new PM needs to invoke add-discriminator pass when building with -fdebug-info-for-profiling. https://reviews.llvm.org/D35746 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp ===