hans added a comment.
Thanks for fixing this long-standing TODO :-)
Repository:
rL LLVM
https://reviews.llvm.org/D35427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
@chapuni - many thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D35427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chapuni added inline comments.
Comment at: cfe/trunk/test/FixIt/format.m:240
+ int x;
+ printf("%zn", &x); // expected-warning{{format specifies type 'ssize_t *'
(aka 'long *') but the argument has type 'int *'}}
+ // PrintfSpecifier::fixType doesn't handle %n, so a fix-it is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308067: [clang] Fix handling of "%zd" format specifier
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D35427?vs=106694&id=106726#toc
Repository:
rL LLVM
https://reviews.ll
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D35427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
alexshap updated this revision to Diff 106694.
alexshap added a comment.
Address comments
Repository:
rL LLVM
https://reviews.llvm.org/D35427
Files:
lib/Analysis/PrintfFormatString.cpp
test/FixIt/format.m
Index: test/FixIt/format.m
==
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: lib/Analysis/PrintfFormatString.cpp:539
case LengthModifier::AsSizeT:
return ArgType(); // FIXME: ssize_t
case LengthModifier::AsPtrDiff:
What a
alexshap created this revision.
This diff addresses FIXME in lib/Analysis/PrintfFormatString.cpp
and makes Clang warn on incorrect using of "%zd" format specifier.
Test plan: make check-all
Repository:
rL LLVM
https://reviews.llvm.org/D35427
Files:
lib/Analysis/PrintfFormatString.cpp
te
