EricWF added a comment.
@rsmith Should this be considered for the `5.0` release?
https://reviews.llvm.org/D35297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D35297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
EricWF updated this revision to Diff 108845.
EricWF added a comment.
- Address issues in inline comments. The patch should be ready to go now :-)
https://reviews.llvm.org/D35297
Files:
lib/Sema/SemaLookup.cpp
test/SemaCXX/overloaded-operator.cpp
Index: test/SemaCXX/overloaded-operator.cpp
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:229
assert(!Redeclaration && "cannot do redeclaration operator lookup");
-IDNS = Decl::IDNS_NonMemberOperator;
+IDNS = Decl::IDNS_NonMemberOperator | Decl::IDNS_LocalExtern;
break;
---
EricWF added a comment.
@rsmith Ping. This should be super simple to review.
https://reviews.llvm.org/D35297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 106168.
EricWF edited the summary of this revision.
https://reviews.llvm.org/D35297
Files:
lib/Sema/SemaLookup.cpp
test/SemaCXX/overloaded-operator.cpp
Index: test/SemaCXX/overloaded-operator.cpp
==
EricWF updated this revision to Diff 106166.
EricWF added a comment.
Add more appropriate test.
https://reviews.llvm.org/D35297
Files:
lib/Sema/SemaLookup.cpp
test/SemaCXX/overloaded-operator.cpp
Index: test/SemaCXX/overloaded-operator.cpp
=
EricWF created this revision.
Previously Clang was not considering operator declarations that occur at
function scope. This is incorrect according to [over.match.oper]p3
> The set of non-member candidates is the result of the unqualified lookup of
> operator@ in the context of the expression ac
