This revision was automatically updated to reflect the committed changes.
Closed by commit rL307795: [clang-format] Keep level of comment before an empty
line (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D35296
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/tru
krasimir updated this revision to Diff 106220.
krasimir marked 2 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D35296
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestComments.cpp
Index
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Some small comments, otherwise looks good.
Comment at: lib/Format/TokenAnnotator.cpp:1706
+if (NextNonCommentLine && CommentLine) {
+ bool UpdateLevel = NextNonCom
krasimir updated this revision to Diff 106205.
krasimir added a comment.
- Update switch tests
https://reviews.llvm.org/D35296
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestComments.cpp
Index: unittests/Format/FormatTestComments.cpp
=
krasimir updated this revision to Diff 106202.
krasimir added a comment.
- Switch to original column-based detection
https://reviews.llvm.org/D35296
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestComments.cpp
Index: unittests/Format/FormatTestComments.cpp
=
djasper added a comment.
I still think we should make this dependent on the current indentation. Why do
you think this is better?
https://reviews.llvm.org/D35296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
krasimir created this revision.
Herald added a subscriber: klimek.
This patch fixes bug https://bugs.llvm.org/show_bug.cgi?id=3313: a comment line
was aligned with the next #ifdef even in the presence of an empty line between
them.
https://reviews.llvm.org/D35296
Files:
lib/Format/TokenAnnota
