[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk added a comment. Seems to have worked: Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ... A test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml A test/clang-apply-replacements/invalid-files.cpp M c

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

This revision was automatically updated to reflect the committed changes. Closed by commit rL308974: [clang-tidy] clang-apply-replacements: Don't insert null entry (authored by kfunk). Repository: rL LLVM https://reviews.llvm.org/D35194 Files: clang-tools-extra/trunk/clang-apply-replacemen

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Do you need someone to commit the patch for you? https://reviews.llvm.org/D35194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk updated this revision to Diff 108061. kfunk added a comment. Addressed concerns https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml test/clang-apply-replacements/inval

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you for the fix! A few comments below. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:291-299 const FileEntry *Entry = SM.getFi

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:296 + << "' doesn't exist. Ignoring...\n"; +} continue; yawanng wrote: > Maybe add some error message here if it's not an existenc

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

yawanng added a comment. LGTM. Please wait for Alexander approval. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:296 + << "' doesn't exist. Ignoring...\n"; +} continue; Maybe add some error message here

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk updated this revision to Diff 105929. kfunk added a comment. Remove unnecessary `sed` line in test driver https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml test/clan

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk updated this revision to Diff 105928. kfunk added a comment. Add test https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml test/clang-apply-replacements/invalid-files.c