arphaman added a comment.
Committed r307771 with correct attribution.
Repository:
rL LLVM
https://reviews.llvm.org/D35187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307769: [libclang] Support for querying whether an enum is
scoped (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D35187?vs=106066&id=106173#toc
Repository:
rL LLVM
https:/
arphaman added a comment.
Sure, I'll commit it today.
https://reviews.llvm.org/D35187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jklaehn added a comment.
I do not have commit access, it would be great if you could commit it. Thanks!
https://reviews.llvm.org/D35187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM. Do you have commit access or would you like me to commit it on your
behalf?
https://reviews.llvm.org/D35187
___
cfe-commits mailing li
jklaehn updated this revision to Diff 106066.
jklaehn added a project: clang.
https://reviews.llvm.org/D35187
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor.py
include/clang-c/Index.h
test/Index/print-type-declaration.cpp
tools/c-index-test/c-index-test.
arphaman added a comment.
Thanks for the patch.
I have just one minor comment:
Comment at: tools/libclang/CIndex.cpp:7815
+ const Decl *D = cxcursor::getCursorDecl(C);
+ const EnumDecl *Enum = D ? dyn_cast_or_null(D) : nullptr;
+ return (Enum && Enum->isScoped()) ? 1 : 0;
--
jklaehn created this revision.
This patch allows checking whether an enum declaration is scoped
through libclang and clang.cindex (Python).
https://reviews.llvm.org/D35187
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor.py
include/clang-c/Index.h
test/Ind
