This revision was automatically updated to reflect the committed changes.
Closed by commit rL308012: [analyzer] Add annotation for functions taking
user-facing strings (authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D35186?vs=105792&id=106605#toc
Repository:
rL LLVM
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Thanks for the patch! This looks very good to me.
The one thing I would suggest is renaming 'isAnnotatedAsLocalized()' and
'isAnnotatedTakingLocalized()' to make it more clear what each
erikjv updated this revision to Diff 105792.
erikjv added a comment.
Sorry, now with more context in the diff.
https://reviews.llvm.org/D35186
Files:
lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
test/Analysis/localization-aggressive.m
Index: test/Analysis/localization-aggressive.m
=
erikjv created this revision.
Herald added a subscriber: xazax.hun.
There was already a returns_localized_nsstring annotation to indicate
that the return value could be passed to UIKit methods that would
display them. However, those UIKit methods were hard-coded, and it was
not possible to indicat
