This revision was automatically updated to reflect the committed changes.
Closed by commit rL308008: Keep the IdentifierInfo in the Token for alternative
operator keyword (authored by ogoffart).
Changed prior to commit:
https://reviews.llvm.org/D35172?vs=105816&id=106594#toc
Repository:
rL L
ogoffart updated this revision to Diff 105816.
https://reviews.llvm.org/D35172
Files:
include/clang/Basic/IdentifierTable.h
lib/Lex/PPDirectives.cpp
lib/Lex/PPExpressions.cpp
lib/Lex/Preprocessor.cpp
test/Parser/MicrosoftExtensions.cpp
test/Preprocessor/cxx_oper_keyword.cpp
unittest
ogoffart updated this revision to Diff 105815.
ogoffart marked an inline comment as done.
ogoffart added a comment.
Added check for "#if and_eq"
https://reviews.llvm.org/D35172
Files:
include/clang/Basic/IdentifierTable.h
lib/Lex/PPDirectives.cpp
lib/Lex/PPExpressions.cpp
lib/Lex/Prepr
ogoffart marked an inline comment as done.
ogoffart added inline comments.
Comment at: lib/Lex/PPExpressions.cpp:242
switch (PeekTok.getKind()) {
- default: // Non-value token.
+ default:
+// If this token's spelling is a pp-identifier, check to see if it is
---
rsmith added a comment.
It looks like there are fewer special cases with this direction then our
present one, though I worry that they'll be less obvious. On the whole, this
seems like a improvement.
Comment at: lib/Lex/PPExpressions.cpp:242
switch (PeekTok.getKind()) {
-
erichkeane added a comment.
My interaction with this is as a submitter for Melanie, so hopefully she can
validate that this doesn't break anything subtle. To me it DOES seem like a
good approach, however Richard likely has a better idea about it, so I want to
give him a bit of time before acce
ogoffart created this revision.
Herald added a subscriber: klimek.
The goal of this commit is to fix clang-format so it does not merge tokens when
using the alternative spelling keywords. (eg: "not foo" should not become
"notfoo")
The problem is that Preprocessor::HandleIdentifier used to drop t
