[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-24 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308899: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34972 Files: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp cfe/trunk/test/CodeGenCXX/

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-24 Thread David Majnemer via Phabricator via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-22 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 107795. smeenai edited the summary of this revision. smeenai added a comment. Add comment https://reviews.llvm.org/D34972 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/dllexport-vtable-thunks.cpp Index: test/CodeGenCXX/dllexport-vtable-thunks.c

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-21 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. OK, so we are exporting the thunks so that the linker will generate import thunks for the thunks. I think that we should have a comment to that effect near the code you added. https://reviews.llvm.org/D34972 ___ cfe-commi

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-21 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Ping. I updated the description based on the email discussion with @majnemer. https://reviews.llvm.org/D34972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread Shoaib Meenai via cfe-commits
, "reviews+d34972+public+8a22767368a5b...@reviews.llvm.org" , "r...@google.com" Cc: "cfe-commits@lists.llvm.org" , "ztur...@google.com" Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks If the thinks are not imported, why would it make sense

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread David Majnemer via cfe-commits
g" , " > reviews+d34972+public+8a22767368a5b...@reviews.llvm.org" < > reviews+d34972+public+8a22767368a5b...@reviews.llvm.org>, "r...@google.com" > > Cc: "ztur...@google.com" , "cfe-commits@lists.llvm.org" > > Subject: Re: [PATCH]

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread Shoaib Meenai via cfe-commits
i via Phabricator , "compn...@compnerd.org" , "reviews+d34972+public+8a22767368a5b...@reviews.llvm.org" , "r...@google.com" Cc: "ztur...@google.com" , "cfe-commits@lists.llvm.org" Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread David Majnemer via cfe-commits
What about the import side? On Mon, Jul 3, 2017 at 10:37 PM Shoaib Meenai via Phabricator via cfe-commits wrote: > smeenai created this revision. > > Under Windows Itanium, we need to export virtual and non-virtual thunks > if the functions being thunked are exported. These thunks would > previo

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-03 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport attribute