dblaikie added a comment.
If possible, please upload patches with full context - makes it easier to check
around nearby code when reviewing. (the 'arc' tool for phab helps with this)
Comment at: include/clang/AST/Redeclarable.h:257-261
if (PassedFirst) {
- as
v.g.vassilev added a comment.
Sure, I can do this, as long as this semantic change is ok.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rsmith added a comment.
You should remove the code after the `assert(0)`, or you'll trigger
"unreachable code" warnings.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
v.g.vassilev added a comment.
Ok, thanks! I was hesitant for the changes in libclang, because of the return
statements.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, post-commit review is fine for changes like this.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-c
v.g.vassilev created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
Files:
include/clang/AST/Redeclarable.h
lib/AST/ExprConstant.cpp
lib/Basic/SourceManager.cpp
lib/Lex/PreprocessingRecord.cpp
lib/Sema/SemaType.cpp
lib/Serialization/ASTReader.cpp
lib/Serializa
