[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

2017-06-30 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Sorry about the breakage. I'll redo this limiting it to windows-itanium (and add a comment explaining why we want it). Repository: rL LLVM https://reviews.llvm.org/D34850 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

2017-06-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. This appears to affect our behavior under the MS ABI. We still seem to use this logic from CGVTables, even though that code is primarily Itanium related. In http://crbug.com/738468 we're seeing the LNK4102 linker warning, which says: "export of deleting destructor (name); i

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

2017-06-29 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306770: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34850 Files: cfe/trunk/lib/CodeGen/CGVTables.cpp cfe/trunk/test/CodeGenCXX/wind

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

2017-06-29 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport attribute