johannes abandoned this revision.
johannes added a comment.
split up in several commits starting from https://reviews.llvm.org/D36176
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:170
+ // Ignore everything from other files.
+ if (!SrcMgr.isInMainFile(SLoc))
+return true;
-
arphaman added a comment.
In general this patch is too big, and combines a lot of changes that could be
separated using multiple patches. I've suggested one pre-commit and a new patch
so far, but more changes might be required once I see the updated patch.
Comment at: include
johannes updated this revision to Diff 108370.
johannes retitled this revision from "[clang-diff] improve mapping accuracy,
HTML side-by-side diff." to "[clang-diff] improve mapping accuracy".
https://reviews.llvm.org/D34748
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Toolin
arphaman added a comment.
Some comments:
- I had to make a couple of post-commit fixes to appease the buildbots when I
committed your first patch, so it looks like this one doesn't apply cleanly
anymore. Can you please rebase it?
- Let's separate the addition of HTML output and the improvements
johannes updated this revision to Diff 107479.
johannes retitled this revision from "[clang-diff] Fix multiple mappings." to
"[clang-diff] improve mapping accuracy, HTML side-by-side diff.".
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D34748
Files:
include/clang/Tooling/ASTDiff
