This revision was automatically updated to reflect the committed changes.
Closed by commit rL306489: [COFF, ARM64] Add support for Windows ARM64 COFF
format (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D34706?vs=104308&id=104317#toc
Repository:
rL LLVM
https://rev
ruiu accepted this revision.
ruiu added a comment.
LGTM. I don't think I have enough knowledge to sign off, but as Saleem has
already LGTM'ed, I guess it should be okay.
https://reviews.llvm.org/D34706
___
cfe-commits mailing list
cfe-commits@lists
mgrang updated this revision to Diff 104308.
mgrang added a comment.
Comments addressed.
https://reviews.llvm.org/D34706
Files:
lib/Basic/Targets.cpp
test/Preprocessor/predefined-macros.c
Index: test/Preprocessor/predefined-macros.c
ruiu added inline comments.
Comment at: lib/Basic/Targets.cpp:6553
+class MicrosoftARM64leTargetInfo
+: public WindowsTargetInfo {
I cannot imagine there will be MicrosoftARM64beTargetInfo, so I wonder if we
should name this MicrosoftARM64TargetInfo.
htt
mgrang added a comment.
Here is the llvm part of this patch: https://reviews.llvm.org/D34705
https://reviews.llvm.org/D34706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang created this revision.
Herald added subscribers: kristof.beyls, aemerson.
This is the clang part of the initial implementation to support Windows ARM64
COFF format.
https://reviews.llvm.org/D34706
Files:
lib/Basic/Targets.cpp
test/Preprocessor/predefined-macros.c
Index: test/Prepr
