davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D34663
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
danielcdh added inline comments.
Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:39
+// O2: if.true.direct_targ
// ThinLTO-NOT: if.true.direct_targ
void icp(void (*p)()) {
davidxl wrote:
> Is the thinLTO behavior here expected?
Yes, it's expected, icp is
davidxl added inline comments.
Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:39
+// O2: if.true.direct_targ
// ThinLTO-NOT: if.true.direct_targ
void icp(void (*p)()) {
Is the thinLTO behavior here expected?
https://reviews.llvm.org/D34663
_
danielcdh updated this revision to Diff 104199.
danielcdh added a comment.
update comments
https://reviews.llvm.org/D34663
Files:
test/CodeGen/pgo-sample-thinlto-summary.c
Index: test/CodeGen/pgo-sample-thinlto-summary.c
===
--