[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

2017-07-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL309459: [ubsan] Diagnose invalid uses of builtins (clang) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34590?vs=103827&id=108753#toc Repository: rL LLVM https://reviews.

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

2017-07-28 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. Looks fine to me. https://reviews.llvm.org/D34590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

2017-07-28 Thread Vedant Kumar via Phabricator via cfe-commits
vsk edited reviewers, added: eugenis; removed: efriedma. vsk added a comment. Ping. https://reviews.llvm.org/D34590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

2017-06-26 Thread Eli Friedman via Phabricator via cfe-commits
efriedma resigned from this revision. efriedma added a comment. The check itself looks okay, but I'm not really familiar with the other ubsan bits. https://reviews.llvm.org/D34590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

2017-06-23 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. On some targets, passing zero to the clz() or ctz() builtins has undefined behavior. I ran into this issue while debugging UB in __hash_table from libcxx: the bug I was seeing manifested itself differently under -O0 vs -Os, due to a UB call to clz() (see: libcxx/r304617)