[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

2017-06-27 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r306444 https://reviews.llvm.org/D34580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

2017-06-26 Thread Dave Lee via Phabricator via cfe-commits
kastiglione added a comment. Thanks @rnk. I don't have commit access; @compnerd, @rnk would either of you mind committing this? Thanks in advance! https://reviews.llvm.org/D34580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

2017-06-26 Thread Dave Lee via Phabricator via cfe-commits
kastiglione updated this revision to Diff 103994. kastiglione added a comment. CHECK load and call https://reviews.llvm.org/D34580 Files: lib/CodeGen/CGDecl.cpp test/CodeGenObjCXX/arc-indirect.mm Index: test/CodeGenObjCXX/arc-indirect.mm ===

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

2017-06-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/CodeGenObjCXX/arc-indirect.mm:19 +// CHECK-DARWIN: define internal void @"\01-[C object:struct:]"(<{ %0*, i8*, i8*, %struct.S, [3 x i8] }>* inalloca) +// CHE

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

2017-06-23 Thread Dave Lee via Phabricator via cfe-commits
kastiglione created this revision. When generating a prolog, add loads for ARC arguments passed indirectly. https://reviews.llvm.org/D34580 Files: lib/CodeGen/CGDecl.cpp test/CodeGenObjCXX/arc-indirect.mm Index: test/CodeGenObjCXX/arc-indirect.mm ==