erichkeane added a comment.
Thanks Reid!
Repository:
rL LLVM
https://reviews.llvm.org/D34455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305928: Correct VectorCall x86 (32 bit) behavior for SSE
Register Assignment (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D34455?vs=103391&id=103412#toc
Repository:
rL
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Oh joy. :)
lgtm, thanks for debugging this. The difference makes sense after the fact when
you think about Win x64's approach to va_arg and /homeparams, and how that
isn't relevant for x86.
https
erichkeane created this revision.
In running some internal vectorcall tests in 32 bit mode, we discovered that
the behavior I'd previously implemented for x64 (and applied to x32) regarding
the assignment of SSE registers was incorrect. See spec here:
https://msdn.microsoft.com/en-us/library/d