aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180
+class CE {
+ constexpr static int i = 5; // OK: constexpr definition.
+};
hokein wrote:
> aaron.ballman wrote:
> > xazax.hun wrote:
> > > hokein wrote:
> > > >
hokein added inline comments.
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180
+class CE {
+ constexpr static int i = 5; // OK: constexpr definition.
+};
aaron.ballman wrote:
> xazax.hun wrote:
> > hokein wrote:
> > > hokein wrote:
> > > > aaron.b
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180
+class CE {
+ constexpr static int i = 5; // OK: constexpr definition.
+};
xazax.hun wrote:
> hokein wrote:
> > hokein wrote:
> > > aaron.ballman wrote:
> > > >
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306538: [clang-tidy] Enable inline variable definitions in
headers (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D34449?vs=104379&id=104389#toc
Repository:
rL LLVM
https://r
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1
-// RUN: %check_clang_tidy %s misc-definitions-in-headers %t
+// RUN: %check_clang_tidy %s m
xazax.hun added inline comments.
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1
-// RUN: %check_clang_tidy %s misc-definitions-in-headers %t
+// RUN: %check_clang_tidy %s misc-definitions-in-headers %t -- -- -std=c++1z
hokein wrote:
> hokein wrot
xazax.hun updated this revision to Diff 104379.
xazax.hun added a comment.
- Unbreak the constexpr test.
https://reviews.llvm.org/D34449
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
docs/clang-tidy/checks/misc-definitions-in-headers.rst
test/clang-tidy/misc-definitions-in-headers-
xazax.hun updated this revision to Diff 104360.
xazax.hun marked 2 inline comments as done.
xazax.hun retitled this revision from "[clang-tidy] Enable constexpr
definitions in headers. " to "[clang-tidy] Enable inline variable definitions
in headers. ".
xazax.hun edited the summary of this revisi
