[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

2017-07-17 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added a comment. Looks good, but I don't know this code well enough to stamp LGTM. Richard? Repository: rL LLVM https://reviews.llvm.org/D34430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

2017-07-10 Thread Oleg Ranevskyy via Phabricator via cfe-commits
iid_iunknown added a comment. A gentle reminder about this patch. Repository: rL LLVM https://reviews.llvm.org/D34430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

2017-06-21 Thread Oleg Ranevskyy via Phabricator via cfe-commits
iid_iunknown added a comment. No hang with this patch on the test case from PR33484. Clang reports a number of expected compilation errors instead. Repository: rL LLVM https://reviews.llvm.org/D34430 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

2017-06-20 Thread Oleg Ranevskyy via Phabricator via cfe-commits
iid_iunknown updated this revision to Diff 103297. iid_iunknown added a comment. Fixed white spaces. Repository: rL LLVM https://reviews.llvm.org/D34430 Files: lib/Sema/SemaExprCXX.cpp Index: lib/Sema/SemaExprCXX.cpp === ---

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

2017-06-20 Thread Oleg Ranevskyy via Phabricator via cfe-commits
iid_iunknown created this revision. iid_iunknown added a project: clang. This is a patch for PR33484. The clang's typo correction logic may fall into an infinite loop when reaching the typo correction limit. When some complex expression has multiple typos in it, clang finds possible corrections