This revision was automatically updated to reflect the committed changes.
Closed by commit rL306874: clang-format: add options to merge empty record body
(authored by Typz).
Repository:
rL LLVM
https://reviews.llvm.org/D34395
Files:
cfe/trunk/include/clang/Format/Format.h
cfe/trunk/lib/Fo
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D34395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Typz updated this revision to Diff 103939.
Typz added a comment.
Merge `SplitEmptyClass/Struct/Union` options into a single `SplitEmptyRecord`
option.
https://reviews.llvm.org/D34395
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/Unwrappe
djasper added a comment.
Yes merge them into those two, please. I think we introduced the others because
of some linux style, but generally lets try not to introduce options that
people aren't going to use.
https://reviews.llvm.org/D34395
___
cfe-
Typz added a comment.
I don't know if some style would want different styles, and I agree with you on
principle; but since the brace wrapping is already configured for each kind of
record, I choose to keep things consistent and have flags for each kind of
record.
But I can merge the options, an
djasper added a comment.
Do you know of a style guide that would actually want to handle class, structs
and unions differently? In most of Clang, they are handled as "records" and
fundamentally, they are so alike that I'd hope that people always want the same
behavior for all of them.
https:/
Typz added a comment.
ping?
https://reviews.llvm.org/D34395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 103202.
Typz added a comment.
Enable merging records for Mozilla style
https://reviews.llvm.org/D34395
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTe
Typz created this revision.
Herald added a subscriber: klimek.
This patch introduces a few extra BraceWrapping options, similar to
`SplitEmptyFunction`, to allow merging empty 'record' bodies (e.g.
class, struct, union and namespace):
- SplitEmptyClass
- SplitEmptyStruct
- SplitEmptyUnion
- Split
