This revision was automatically updated to reflect the committed changes.
Closed by commit rL305875: Support MS builtins using 'long' on LP64 platforms
(authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D34377?vs=103315&id=103318#toc
Repository:
rL LLVM
https://reviews.l
rnk accepted this revision.
rnk added a comment.
lgtm, thanks for shuffling all the tests around!
https://reviews.llvm.org/D34377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 103315.
bruno marked an inline comment as done.
bruno added a comment.
Addressing comments!
https://reviews.llvm.org/D34377
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86.def
include/clang/B
bruno marked 3 inline comments as done.
bruno added inline comments.
Comment at: test/CodeGen/ms-intrinsics-darwin.c:1
+// RUN: %clang_cc1 -ffreestanding -fms-extensions \
+// RUN: -triple x86_64--darwin -Oz -emit-llvm %s -o - \
rnk wrote:
> I'd rather ge
rnk added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// N -> 'L' if target is LP64, 'int' size otherwise.
// S -> signed
Fix the comment? "long" if target is LLP64, "int" otherwise?
Comment at:
bruno updated this revision to Diff 103287.
bruno retitled this revision from "Support MS builtins using 'long' on
Darwin/LP64" to "Support MS builtins using 'long' on LP64".
bruno edited the summary of this revision.
bruno added a comment.
New patch addressing comments from reviewers.
https://
