[PATCH] D34233: [CFI] Add ability to explicitly link classes

2017-06-15 Thread Enes Goktas via Phabricator via cfe-commits
egoktas added a comment. To address pcc's questions, I have sent an email to llvm-dev: http://lists.llvm.org/pipermail/llvm-dev/2017-June/114168.html. https://reviews.llvm.org/D34233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D34233: [CFI] Add ability to explicitly link classes

2017-06-14 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Before looking at this patch in detail, can you please explain the need for this feature? How difficult would it be to change your code to avoid relying on invalid casts? https://reviews.llvm.org/D34233 ___ cfe-commits mailing

[PATCH] D34233: [CFI] Add ability to explicitly link classes

2017-06-14 Thread Enes Goktas via Phabricator via cfe-commits
egoktas updated this revision to Diff 102641. egoktas added a comment. Remove the edits to CGExpr.cpp which accidentally got included in the diff. https://reviews.llvm.org/D34233 Files: include/clang/Basic/SanitizerBlacklist.h lib/Basic/SanitizerBlacklist.cpp lib/CodeGen/CGVTables.cpp l

[PATCH] D34233: [CFI] Add ability to explicitly link classes

2017-06-14 Thread Enes Goktas via Phabricator via cfe-commits
egoktas created this revision. egoktas created this object with visibility "All Users". User can explicitly specify classlinks in a sanitizer blacklist file. During compilation with Control-Flow Integrity (CFI), the specified classes will be linked so that (vtables of) the class type Y can be us