This revision was automatically updated to reflect the committed changes.
Closed by commit rL31: [analyzer] Performance optimizations for the
CloneChecker (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D34182?vs=108839&id=113361#toc
Repository:
rL LLVM
https:
teemperor updated this revision to Diff 108839.
teemperor added a comment.
(Fixed diff)
https://reviews.llvm.org/D34182
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/StaticAnalyzer/Checkers/CloneChecker.cpp
Index: lib/StaticAnalyzer/Checkers/CloneChec
teemperor updated this revision to Diff 108837.
teemperor added a comment.
Herald added a subscriber: klimek.
- Updated according to Artem's comments.
https://reviews.llvm.org/D34182
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/Format/UnwrappedLinePar
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Totally makes sense :)
Comment at: include/clang/Analysis/CloneDetection.h:258-260
+/// This constraint is also available to be executed in two phases, see
+/// RecursiveCloneTypeI
teemperor updated this revision to Diff 102700.
teemperor marked an inline comment as done.
teemperor added a comment.
- made saveHash static.
https://reviews.llvm.org/D34182
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/StaticAnalyzer/Checkers/CloneCh
teemperor added inline comments.
Comment at: include/clang/Analysis/CloneDetection.h:263
+public:
+ void constrain(std::vector &Sequences);
+};
v.g.vassilev wrote:
> Could we typedef `std::vector` into
> `CloneDetector::CloneGroups`?
Yes, I'll do this in anothe
v.g.vassilev added inline comments.
Comment at: include/clang/Analysis/CloneDetection.h:263
+public:
+ void constrain(std::vector &Sequences);
+};
Could we typedef `std::vector` into
`CloneDetector::CloneGroups`?
https://reviews.llvm.org/D34182
___
teemperor created this revision.
Herald added a subscriber: xazax.hun.
This patch aims at optimizing the CloneChecker for larger programs. Before
this patch we took around 102 seconds to analyze sqlite3 with a complexity
value of 50. After this patch we now take 2.1 seconds to analyze sqlite3.